Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to be independent of the path package #139

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

blendthink
Copy link
Member

Issue

Overview (Required)

The path package was introduced to utilize the path.join() function.
path.join() is a function that concatenates the specified path segments into a single path using the separator of the current platform.
https://pub.dev/documentation/path/latest/path/join.html

To maintain the previous behavior, I implemented only the necessary parts manually.

Links

Screenshot

2024-09-19.8.31.54.mov

Copy link
Contributor

Ready for review 🚀

Copy link
Contributor

@morikann morikann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been able to confirm that it works in a Windows environment, but it is LGTM since there is no problem in the code!

@blendthink blendthink merged commit 6817399 into main Jan 7, 2025
2 checks passed
@blendthink blendthink deleted the improve/remove-path-package branch January 7, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants