-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package version to 2.2.0 #135
Conversation
Ready for review 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that there is no difference in the contents of all all.yaml's in Dart.
Test Code
import 'dart:io';
import 'package:test/test.dart';
void main() {
final dartSdkVersions = [
'2.17',
'2.18',
'2.19',
'3.0',
'3.1',
'3.2',
'3.3',
'3.4',
];
final regex = RegExp(r'^- (?<name>[a-zA-Z_]+)\s+(.*)$');
for (final dartSdkVersion in dartSdkVersions) {
group(
'Whether there is a difference: $dartSdkVersion',
() {
final oldContent = File(
'test/old/dart/$dartSdkVersion/all.yaml',
).readAsStringSync();
final newContent = File(
'test/new/dart/$dartSdkVersion/all.yaml',
).readAsStringSync();
final newContents = newContent.split('\n');
for (final newContent in newContents) {
final content = newContent.trim();
final a = regex.firstMatch(content);
final lintName = a?.namedGroup('name');
if (lintName == null) {
continue;
}
test(
'lint rule: $lintName',
() {
expect(
oldContent.contains('- $lintName'),
isTrue,
);
},
);
}
},
);
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for confirming that the lint rules for each of Flutter and Dart do not differ from the previous one!
LGTM!
|
||
<!-- Links --> | ||
|
||
[Keep a Changelog]: https://keepachangelog.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue
Overview (Required)
The following commit removes the
group
field frommachine/rules.json
and adds thecategories
field:dart-lang/sdk@c50c194
The above destructive change broke the automatic lint rule generation workflow and has been corrected to work.
Broken workflow:
https://github.com/yumemi-inc/flutter-yumemi-lints/actions/runs/10311663289
Lint rules added in Dart 3.5:
There are no lint rules added in Flutter 3.24.
Links