Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL-Compatibility, SQL Feature Coverage, PG Extensions #11602
Add PostgreSQL-Compatibility, SQL Feature Coverage, PG Extensions #11602
Changes from 14 commits
f73e0fd
23bca4b
ccdd882
8dd999b
944ae38
2519f96
32b8290
f59ecec
6a10dd0
f3b546f
7ffa7a2
f71fb93
5042b4e
b7b6d40
3477ba6
c9cc5a8
3e3e2b2
53adcb6
3eb0abf
12eee84
2d167f9
f21be8b
179b90f
64f7d52
9c7343c
d8d95b5
dfe39db
97b7639
aeb60be
f346566
d973ec4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to me like the features that are under Going beyond SQL section: https://docs.yugabyte.com/latest/explore/ysql-language-features/. If that's the case, we may just need to link it to that page and not duplicate it to two pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this sub-section altogether, this doesn't have any concrete content yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try formatting your tables like this :
ALTER TABLE
I also think we can replace Details with Documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to Floating point numbers : https://docs.yugabyte.com/latest/api/ysql/datatypes/type_numeric/#floating-point-numbers