Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBZ-PGYB] Implement metrics for multi task model #26069

Closed
yugabyte-ci opened this issue Feb 17, 2025 · 0 comments · Fixed by yugabyte/debezium#165
Closed

[DBZ-PGYB] Implement metrics for multi task model #26069

yugabyte-ci opened this issue Feb 17, 2025 · 0 comments · Fixed by yugabyte/debezium#165
Assignees
Labels
area/cdc Change Data Capture area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Feb 17, 2025

Jira Link: DB-15396

Currently, the connector follows a single task single partition model and thus uses the DefaultChangeEventSourceMetricsFactory which doesn't let us override the metric object names. Since we cannot override names, this causes an issue when we go for the multi task model as there's a conflict in the metric object names if a task registers its metric objects and subsequent tasks try to register their metric objects too.

@yugabyte-ci yugabyte-ci added area/cdc Change Data Capture area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Feb 17, 2025
vaibhav-yb added a commit to yugabyte/debezium that referenced this issue Feb 24, 2025
…task model (#165)

## Problem

Currently, the connector follows a single task single partition model
and thus uses the `DefaultChangeEventSourceMetricsFactory` which doesn't
let us override the metric object names. Since we cannot override names,
this causes an issue when we go for the multi task model as there's a
conflict in the metric object names if a task registers its metric
objects and subsequent tasks try to register their metric objects too.

## Solution

This is resolved by adding a custom metrics implementation which lets us
customise things accordingly for a multi task model. This is done by
following the example of metrics implemented by SqlServerConnector at
https://github.com/yugabyte/debezium/tree/2.5.2.Final/debezium-connector-sqlserver/src/main/java/io/debezium/connector/sqlserver/metrics

This closes yugabyte/yugabyte-db#26069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cdc Change Data Capture area/cdcsdk CDC SDK jira-originated kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants