Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Add 2024.2.0 upgrade tests #24231

Closed
1 task done
hari90 opened this issue Oct 1, 2024 · 0 comments
Closed
1 task done

[DocDB] Add 2024.2.0 upgrade tests #24231

hari90 opened this issue Oct 1, 2024 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@hari90
Copy link
Contributor

hari90 commented Oct 1, 2024 •
edited by jira bot
Loading

Jira Link: DB-13123

Description

Add 2024.2.0 upgrade tests

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hari90 hari90 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Oct 1, 2024
@hari90 hari90 self-assigned this Oct 1, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Oct 1, 2024
hari90 added a commit that referenced this issue Oct 3, 2024
@hari90
[#24231] DocDB: Add 2024.2.0.0-b20 to basic upgrade tests
dd5e8fc 
Summary:
Adding 2024.2.0.0-b20 to upgrade test builds.
Parameterize and add 2024.2.0.0 to the basic upgrade tests.

- Ignore `builds.xml` file from linter
- Improve the test to handle transient failures when `allow_errors` flag is reset in the middle of a statement.
- Use a short statement timeout to prevent queries from getting stuck. This was occuring in mac release builds consistently.
- Removing output, and error string from upgrade_test_base `RunCommand` since this blocks if the output is too large.

Jira: DB-13123

Test Plan: basic_upgrade-test

Reviewers: asrivastava, tfoucher

Reviewed By: tfoucher

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D38609
@hari90 hari90 closed this as completed Oct 3, 2024
foucher pushed a commit that referenced this issue Oct 4, 2024
@yugabyte-ci @foucher
[BACKPORT pg15-cherrypicks] all: Bulk port from master - 119
a7c62af 
Summary:
 a9f733f [docs] added note to EA similar to GA (#24256)
 cc1ca59 [doc][ybm] Move Aeon examples (#24227)
 Excluded: dd5e8fc [#24231] DocDB: Add 2024.2.0.0-b20 to basic upgrade tests

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: fizaa, telgersma, jenkins-bot

Differential Revision: https://phorge.dev.yugabyte.com/D38694
foucher added a commit to foucher/yugabyte-db that referenced this issue Oct 4, 2024
@foucher
Merge commit 'dd5e8fc546db6120ad2a810eeee50e97418da24a' into pg15-mas…
682f55d 
…ter-merge

Merge master commit dd5e8fc titled,
  [yugabyte#24231] DocDB: Add 2024.2.0.0-b20 to basic upgrade tests
and committed 2024-10-03T16:24:33-07:00 into pg15

* nodeLockRows.c
   * ExecLockRows
      * YB master ca7f463 replaced a chunk of code under an `if(true)` statement with `YBCHandleConflictError(erm->relation, erm->waitPolicy)`
      * YB pg15 04e31cf changed the `if(true)` to `if (IsYBBackedRelation(erm->relation))`
      * Resolution: use the condition of pg15 and the body of YB master

* upgrade_test_base.h
    * Bottom of file
        * This commit adds constant string kBuild_2024_2_0_0 and removes classes TestUpgradeFrom_2_20_2_4 and TestUpgradeFrom_2024_1_0_1.
        * pg15-upgrade commit 6623c35 (merged in 8ac3e00) removed the same lines removed in the master commit, removing an extra newline, without adding the constant.
        * Add the new constant, take shared removal, keep the newline.
foucher pushed a commit that referenced this issue Oct 4, 2024
@hari90 @foucher
[BACKPORT pg15-cherrypicks][#24231] DocDB: Add 2024.2.0.0-b20 to basi…
1842fd2 
…c upgrade tests

Summary:
Original commit: dd5e8fc / D38609
Modifications:
  - upgrade_test_base.h:110
    - This commit adds constant string kBuild_2024_2_0_0 and removes classes TestUpgradeFrom_2_20_2_4 and TestUpgradeFrom_2024_1_0_1.
    - pg15-upgrade commit 6623c35 (merged in 8ac3e00) removed the same lines removed in the master commit, removing an extra newline, without adding the constant.
    - Add the new constant, take shared removal, keep the newline.

Adding 2024.2.0.0-b20 to upgrade test builds.
Parameterize and add 2024.2.0.0 to the basic upgrade tests.

- Ignore `builds.xml` file from linter
- Improve the test to handle transient failures when `allow_errors` flag is reset in the middle of a statement.
- Use a short statement timeout to prevent queries from getting stuck. This was occuring in mac release builds consistently.
- Removing output, and error string from upgrade_test_base `RunCommand` since this blocks if the output is too large.

Jira: DB-13123

Test Plan: basic_upgrade-test

Reviewers: fizaa, telgersma, hsunder

Reviewed By: fizaa, hsunder

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D38695
foucher added a commit that referenced this issue Oct 4, 2024
@foucher
Merge commit 'dd5e8fc546db6120ad2a810eeee50e97418da24a' into pg15-mas…
f6ff6cb 
…ter-merge

Merge master commit dd5e8fc titled,
    [#24231] DocDB: Add 2024.2.0.0-b20 to basic upgrade tests
and committed 2024-10-03T16:24:33-07:00 into pg15

* nodeLockRows.c
    * ExecLockRows
        * YB master ca7f463 replaced a chunk of code under an `if(true)` statement with `YBCHandleConflictError(erm->relation, erm->waitPolicy)`
        * YB pg15 04e31cf changed the `if(true)` to `if (IsYBBackedRelation(erm->relation))`
        * Resolution: use the condition of pg15 and the body of YB master

* upgrade_test_base.h
    * Bottom of file
        * YB master commit dd5e8fc adds constant string kBuild_2024_2_0_0 and removes classes TestUpgradeFrom_2_20_2_4 and TestUpgradeFrom_2024_1_0_1.
        * pg15-upgrade commit 6623c35 (merged in YB pg15 8ac3e00) removed the same lines removed in the master commit, removing an extra newline, without adding the constant.
        * Resolution: add the new constant, take shared removal, keep the newline.
foucher added a commit that referenced this issue Oct 4, 2024
@foucher
[pg15] merge: master commit dd5e8fc into pg15
aba2c96 
Summary:
Merge master commit dd5e8fc titled,
    [#24231] DocDB: Add 2024.2.0.0-b20 to basic upgrade tests
and committed 2024-10-03T16:24:33-07:00 into pg15

* nodeLockRows.c
    * ExecLockRows
        * YB master ca7f463 replaced a chunk of code under an `if(true)` statement with `YBCHandleConflictError(erm->relation, erm->waitPolicy)`
        * YB pg15 04e31cf changed the `if(true)` to `if (IsYBBackedRelation(erm->relation))`
        * Resolution: use the condition of pg15 and the body of YB master

* upgrade_test_base.h
    * Bottom of file
        * YB master commit dd5e8fc adds constant string kBuild_2024_2_0_0 and removes classes TestUpgradeFrom_2_20_2_4 and TestUpgradeFrom_2024_1_0_1.
        * pg15-upgrade commit 6623c35 (merged in YB pg15 8ac3e00) removed the same lines removed in the master commit, removing an extra newline, without adding the constant.
        * Resolution: add the new constant, take shared removal, keep the newline.

Test Plan: Jenkins: urgent

Reviewers: fizaa, telgersma

Reviewed By: fizaa

Subscribers: smishra, ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D38698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci