-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yugabyted] Don't send blacklisted gflags info in yugabyted callhome #24029
Labels
2.20.7_blocker
2024.1.3_blocker
2024.2_blocker
area/ecosystem
Label for all ecosystem related projects
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
Currently, collecting gflags information is redundant data between yugabyted and YBDB callhome. It was decided to not send gflags information from yugabyted, instead correlated the data using |
nchandrappa
added a commit
that referenced
this issue
Sep 20, 2024
Summary: Currently, collecting gflags information is redundant data between yugabyted and YBDB callhome. It was decided to not send gflags information from yugabyted, instead correlated the data using cluster_uuid, node_uuid, server_type for fetching the gflags details. Test Plan: manual test Reviewers: sgarg-yb Reviewed By: sgarg-yb Subscribers: yugabyted-dev Differential Revision: https://phorge.dev.yugabyte.com/D38263
nchandrappa
added a commit
that referenced
this issue
Sep 20, 2024
…flags details. Summary: Currently, collecting gflags information is redundant data between yugabyted and YBDB callhome. It was decided to not send gflags information from yugabyted, instead correlated the data using cluster_uuid, node_uuid, server_type for fetching the gflags details. Original commit: 0c84dbe / D38263 Test Plan: manual test Reviewers: sgarg-yb, djiang Reviewed By: djiang Subscribers: djiang, yugabyted-dev Differential Revision: https://phorge.dev.yugabyte.com/D38278
nchandrappa
added a commit
that referenced
this issue
Sep 20, 2024
… gflags details. Summary: Currently, collecting gflags information is redundant data between yugabyted and YBDB callhome. It was decided to not send gflags information from yugabyted, instead correlated the data using cluster_uuid, node_uuid, server_type for fetching the gflags details. Original commit: 0c84dbe / D38263 Test Plan: manual test Reviewers: sgarg-yb, djiang Reviewed By: djiang Subscribers: djiang, yugabyted-dev Differential Revision: https://phorge.dev.yugabyte.com/D38281
nchandrappa
added a commit
that referenced
this issue
Sep 20, 2024
…not to send gflags details. Summary: Currently, collecting gflags information is redundant data between yugabyted and YBDB callhome. It was decided to not send gflags information from yugabyted, instead correlated the data using cluster_uuid, node_uuid, server_type for fetching the gflags details. Original commit: 0c84dbe / D38263 Jira: DB-12919 Test Plan: manual test Reviewers: sgarg-yb, djiang Reviewed By: djiang Subscribers: djiang, yugabyted-dev Differential Revision: https://phorge.dev.yugabyte.com/D38283
foucher
pushed a commit
that referenced
this issue
Sep 24, 2024
Summary: 5d3e83e [PLAT-15199] Change TP API URLs according to latest refactoring a50a730 [doc][yba] YBDB compatibility (#23984) 0c84dbe [#24029] Update the callhome diagnostics not to send gflags details. b53ed3a [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule f0eab8f [PLAT-15278]: Fix DB Scoped XCluster replication restart 344bc76 Revert "[PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule" 3628ba7 [PLAT-14459] Swagger fix bb93ebe [#24021] YSQL: Add --TEST_check_catalog_version_overflow 9ab7806 [#23927] docdb: Add gflag for minimum thread stack size Excluded: 8c8adc0 [#18822] YSQL: Gate update optimizations behind preview flag 5e86515 [#23768] YSQL: Fix table rewrite DDL before slot creation 123d496 [PLAT-14682] Universe task should only unlock itself and make unlock aware of the lock config de9d4ad [doc][yba] CIS hardened OS support (#23789) e131b20 [#23998] DocDB: Update usearch and other header-only third-party dependencies 1665662 Automatic commit by thirdparty_tool: update usearch to commit 240fe9c298100f9e37a2d7377b1595be6ba1f412. 3adbdae Automatic commit by thirdparty_tool: update fp16 to commit 98b0a46bce017382a6351a19577ec43a715b6835. 9a819f7 Automatic commit by thirdparty_tool: update hnswlib to commit 2142dc6f4dd08e64ab727a7bbd93be7f732e80b0. 2dc58f4 Automatic commit by thirdparty_tool: update simsimd to tag v5.1.0. 9a03432 [doc][ybm] Azure private link host (#24086) 039c9a2 [#17378] YSQL: Testing for histogram_bounds in pg_stats 09f7a0f [#24085] DocDB: Refactor HNSW wrappers 555af7d [#24000] DocDB: Shutting down shared exchange could cause TServer to hang 5743a03 [PLAT-15317]Alert emails are not in the correct format. 8642555 [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule 253ab07 [PLAT-15400][PLAT-15401][PLAT-13051] - Connection pooling ui issues and other ui issues 57576ae [#16487] YSQL: Fix flakey TestPostgresPid test bc8ae45 Update ports for CIS hardened (#24098) 6fa33e6 [#18152, #18729] Docdb: Fix test TestPgIndexSelectiveUpdate cc6d2d1 [docs] added and updated cves (#24046) Excluded: ed153dc [#24055] YSQL: fix pg_hint_plan regression with executing prepared statement Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, jenkins-bot Differential Revision: https://phorge.dev.yugabyte.com/D38322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.20.7_blocker
2024.1.3_blocker
2024.2_blocker
area/ecosystem
Label for all ecosystem related projects
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Jira Link: DB-12919
Description
Currently, yugabyted call home sends all the gflags information set with
--master_gflags
and--tserver_gflags
. However, we need to add a blacklist so that certain sensitive gflags will not be sent in the callhome.Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: