PgWaitQueuesTest.MultiTabletFairness unit test frequent failure #23925
Assignees
Labels
2024.1 Backport Required
area/docdb
YugabyteDB core features
kind/bug
This issue is a bug
priority/medium
Medium priority issue
Comments
agsh-yb
added
area/docdb
yugabyte-ci
added
kind/bug
basavaraj29
added a commit
that referenced
this issue
Sep 16, 2024
…ltiTabletFairness Summary: `PgWaitQueuesTest.MultiTabletFairness` has some timing based assertions that started to fail recently. In particular, each thread issues a `select for update...` and waits for all other threads to reach the same state. It seems like enabling shared memory in release mode has caused the flakiness in this test (only on mac release builds), which may be hints at `select for update...` taking longer after the change. But a potential regression affecting latencies due to that change is being looked at separately and it shouldn't have anything to do with this test. here's a snippet of the error we see on mac release builds. ``` ../../src/yb/yql/pgwrapper/pg_wait_on_conflict-test.cc:1317 Value of: queued_waiters.WaitFor(10s * kTimeMultiplier) Actual: false Expected: true ``` This diff addresses the test only issue by executing all reads with explicit lock requests before the for loop with timing based assertions. Jira: DB-12827 Test Plan: ./yb_build.sh release --cxx-test pgwrapper_pg_wait_on_conflict-test --gtest_filter PgWaitQueuesTest.MultiTabletFairness -n 50 --tp 1 Reviewers: rthallam, pjain, patnaik.balivada Reviewed By: patnaik.balivada Subscribers: ybase, yql Differential Revision: https://phorge.dev.yugabyte.com/D38050
rthallamko3
added
2024.1 Backport Required
and removed
status/awaiting-triage
basavaraj29
added a commit
that referenced
this issue
Sep 17, 2024
…WaitQueuesTest.MultiTabletFairness Summary: Original commit: e717f43 / D38050 `PgWaitQueuesTest.MultiTabletFairness` has some timing based assertions that started to fail recently. In particular, each thread issues a `select for update...` and waits for all other threads to reach the same state. It seems like enabling shared memory in release mode has caused the flakiness in this test (only on mac release builds), which may be hints at `select for update...` taking longer after the change. But a potential regression affecting latencies due to that change is being looked at separately and it shouldn't have anything to do with this test. here's a snippet of the error we see on mac release builds. ``` ../../src/yb/yql/pgwrapper/pg_wait_on_conflict-test.cc:1317 Value of: queued_waiters.WaitFor(10s * kTimeMultiplier) Actual: false Expected: true ``` This diff addresses the test only issue by executing all reads with explicit lock requests before the for loop with timing based assertions. Jira: DB-12827 Test Plan: ./yb_build.sh release --cxx-test pgwrapper_pg_wait_on_conflict-test --gtest_filter PgWaitQueuesTest.MultiTabletFairness -n 50 --tp 1 Reviewers: rthallam, pjain, patnaik.balivada Reviewed By: patnaik.balivada Subscribers: yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D38094
jasonyb
pushed a commit
that referenced
this issue
Sep 17, 2024
Summary: f97d7d5 [#23770] [#23797] [#23837] YSQL: Fix most non-regress tests when run with Connection Manager ee2b108 [docs] reverted PR 23909 changes (#23941) bd80f4e [#23924] DocDB: Address recent flakiness of PgGetLockStatusTest.TestGetWaitStart Excluded: f0a5db7 [#20908] YSQL: Introduce interface to optimize index non-key column updates 6556498 [#23897] xClusterDDLRepl: Support create table with partition by primary key e2b1d28 [#23363] Changing the default gflags of YSQL memory configuration. e717f43 [#23925] DocDB: Address recent regression of test PgWaitQueuesTest.MultiTabletFairness 09b7702 [#23940] YSQL: Replace copyright string from YugaByteDB to YugabyteDB add83ef [#23947] Update callhome URL to use https 69db717 Update faq page (#23704) Excluded: 063dbe5 [#23786] YSQL: yb_make_next_ddl_statement_nonincrementing Excluded: a913524 [#23859] YSQL: Remove redundant Bitmap Scan filters on partial indexes 41f5afd [PLAT-15097]: Delete System platform DB table while disabling ysql d6bbf59 [#23890] docdb: Add filtering for bootstrap intent iterators based on min_replay_txn_start_ht 0b37479 [#23770] YSQL: Stabalize TestPgExplainAnalyze#testExplainAnalyzeOptions the test with ysql connection manager Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D38123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12827
Description
PgWaitQueuesTest.MultiTabletFairness this test starts failing frequently after commit on mac12-clang-release-x86_64
Analyze_trends
../../src/yb/yql/pgwrapper/pg_wait_on_conflict-test.cc:1317 Value of: queued_waiters.WaitFor(10s * kTimeMultiplier) Actual: false Expected: trueIssue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: