Skip to content

Commit

Permalink
[PLAT-15791] Don't download sha1 during release create
Browse files Browse the repository at this point in the history
Summary:
we expect a sha256 value, not a sha1. <release_url>.sha has only ever been a sha256 value,
so we cannot use it.

Test Plan: created a release and then a universe with the release

Reviewers: muthu, anijhawan

Reviewed By: muthu

Subscribers: svc_phabricator, yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D39263
  • Loading branch information
shubin-yb committed Oct 22, 2024
1 parent cca8298 commit 182b009
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions managed/src/main/java/com/yugabyte/yw/common/ReleasesUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Scanner;
import java.util.UUID;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
Expand Down Expand Up @@ -142,15 +141,8 @@ public ExtractedMetadata metadataFromPath(Path releaseFilePath) {

public ExtractedMetadata versionMetadataFromURL(URL url) {
// Best effort to get sha256 from url
// The current url is sha1, not sha256. When we get a .sha256 file, we can use that.
String sha256 = null;
try {
URL shaUrl = new URL(url.toString() + ".sha");
Scanner sc = new Scanner(shaUrl.openStream());
sha256 = sc.hasNext() ? sc.next() : null;
log.debug("found sha256 {} from url {}", sha256, shaUrl.toString());
} catch (Exception e) {
log.warn("failed to open sha url ", e);
}
ExtractedMetadata em = new ExtractedMetadata();
try {
if (isHelmChart(url.getFile())) {
Expand Down

0 comments on commit 182b009

Please sign in to comment.