Handle NumberFormatException in debezium while updating sequence max value for sequence on non-integer column #2360
+67
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sequence column in debezium Added a test case for it
| sequenceMax.put(seqName, Math.max(sequenceMax.get(seqName), columnValue)); | ||
| } catch (NumberFormatException e) { | ||
| //Skipping the sequences that are not on Integer columns | ||
| LOGGER.info("Skipping unsupported sequence with non-interger value: '{}'", seqName); |
There was a problem hiding this comment.
Perhaps DEBUG would be better? otherwise this would come up for every single row.
| columnValue = Long.valueOf(value); | ||
| sequenceMax.put(seqName, Math.max(sequenceMax.get(seqName), columnValue)); | ||
| } catch (NumberFormatException e) { | ||
| //Skipping the sequences that are not on Integer columns |
There was a problem hiding this comment.
Can you add more context in the comment on the type of sequences and why they could fail with a NumberFormatException?
| @@ -214,4 +214,39 @@ WITH region_list AS ( | |||
| amount[1 + mod(n, array_length(amount, 1))], | |||
There was a problem hiding this comment.
Is this test already running in live migration & offline with BETA_FAST_DATA_EXPORT?
There was a problem hiding this comment.
Only Offline with Beta_fast mode, we don't run pg_sequences test for live-migration currently
makalaaneesh
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Skipping the max value update for sequences that are non-Integer columns in debezium.
fixes - https://yugabyte.atlassian.net/browse/DB-15398
Describe if there are any user-facing changes
No
How was this pull request tested?
Added an offline test for PG
Does your PR have changes that can cause upgrade issues?