Remove check for ora2pg depedency from guardrails in case of live migration in oracle and mysql #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivanshGahlot
requested review from
priyanshi-yb,
makalaaneesh and
sanyamsinghal
makalaaneesh
approved these changes
Jan 29, 2025
yb-voyager/cmd/export.go
Outdated
| // Issue Link: https://github.com/yugabyte/yb-voyager/issues/2102 | ||
| missingTools = utils.CheckTools("ora2pg") | ||
| // In case if it is not a live migration, then we need to check for ora2pg | ||
| if !changeStreamingIsEnabled(exportType) && !useDebezium { |
There was a problem hiding this comment.
nit: IMO, it's more readable to have !(changeStreamingIsEnabled(exportType) || useDebezium) . i.e. you can read it as if not (live migration OR offline with debezium)
Same for oracle case.
There was a problem hiding this comment.
Please test this manually. we don't have test-cases around this.
sanyamsinghal
approved these changes
Jan 29, 2025
ShivanshGahlot
changed the title
ShivanshGahlot
force-pushed
the
shivansh/remove-ora2pg-dependency
branch
from
54ee9a7 to
5b19c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Removed ora2pg dependency check in case of live migration in oracle and mysql
#2102
Describe if there are any user-facing changes
Nope. Only that user wont be prompted that ora2pg is missing in case of live migration.
How was this pull request tested?
Manually
Does your PR have changes that can cause upgrade issues?