Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not redact password for conn pool connection uri while connecting to DB #2203

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Fix: Do not redact password for conn pool connection uri while connecting to DB #2203

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a83acb2
add md5 conf for passwords for yb cluster
priyanshi-yb Jan 17, 2025
00ada30
fix for not redacting connection uris for conn pool
priyanshi-yb Jan 17, 2025
b54c79a
review comment
priyanshi-yb Jan 17, 2025
4b36842
Revert "review comment"
priyanshi-yb Jan 18, 2025
b738426
deepcopy
priyanshi-yb Jan 20, 2025
f91cd7a
add 2.25 to supported preview versions
priyanshi-yb Jan 20, 2025
6aa224f
Merge branch 'main' into priyanshi/fix-conn-pool-pass
priyanshi-yb Jan 20, 2025
979c379
handle error
priyanshi-yb Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/misc-migtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
docker run -d --name yugabytedb-$version \
-p7000:7000 -p9000:9000 -p15433:15433 -p5433:5433 -p9042:9042 \
yugabytedb/yugabyte:$version \
bin/yugabyted start --background=false --ui=false
bin/yugabyted start --tserver_flags="ysql_hba_conf_csv={host all yugabyte all trust,host all all all md5}" --background=false --ui=false
sleep 20

echo "Test YugabyteDB connection"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mysql-migtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
docker run -d --name yugabytedb \
-p7000:7000 -p9000:9000 -p15433:15433 -p5433:5433 -p9042:9042 \
yugabytedb/yugabyte:${{ matrix.version }} \
bin/yugabyted start --background=false --ui=false
bin/yugabyted start --tserver_flags="ysql_hba_conf_csv={host all yugabyte all trust,host all all all md5}" --background=false --ui=false
sleep 20

- name: Test YugabyteDB connection
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pg-13-migtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
docker run -d --name yugabytedb \
-p7000:7000 -p9000:9000 -p15433:15433 -p5433:5433 -p9042:9042 \
yugabytedb/yugabyte:${{ matrix.version }} \
bin/yugabyted start --background=false --ui=false
bin/yugabyted start --tserver_flags="ysql_hba_conf_csv={host all yugabyte all trust,host all all all md5}" --background=false --ui=false
sleep 20

- name: Test YugabyteDB connection
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pg-17-migtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
docker run -d --name yugabytedb \
-p7000:7000 -p9000:9000 -p15433:15433 -p5433:5433 -p9042:9042 \
yugabytedb/yugabyte:${{ matrix.version }} \
bin/yugabyted start --background=false --ui=false
bin/yugabyted start --tserver_flags="ysql_hba_conf_csv={host all yugabyte all trust,host all all all md5}" --background=false --ui=false
sleep 20

- name: Test YugabyteDB connection
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pg-9-migtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
docker run -d --name yugabytedb \
-p7000:7000 -p9000:9000 -p15433:15433 -p5433:5433 -p9042:9042 \
yugabytedb/yugabyte:${{ matrix.version }} \
bin/yugabyted start --background=false --ui=false
bin/yugabyted start --tserver_flags="ysql_hba_conf_csv={host all yugabyte all trust,host all all all md5}" --background=false --ui=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we just have host all all all md5 ? Just want to avoid "trust" altogether 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I started with that only, but somehow yugabyted wasn't coming up with that conf as yugabyte is a default user maybe trust is required for that, I can take that up later after figuring out how to do that

sleep 20

- name: Test YugabyteDB connection
Expand Down
3 changes: 1 addition & 2 deletions yb-voyager/src/tgtdb/yugabytedb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,7 @@ func (yb *TargetYugabyteDB) InitConnPool() error {
SessionInitScript: getYBSessionInitScript(yb.tconf),
}
yb.connPool = NewConnectionPool(params)
redactedParams := params
redactedParams.ConnUriList = utils.GetRedactedURLs(redactedParams.ConnUriList)
redactedParams := *params
log.Info("Initialized connection pool with settings: ", spew.Sdump(redactedParams))
return nil
}
Expand Down
Loading