Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex parser for parsing functions having SQL body with language sql (PG 15 feature) #2201

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Fix regex parser for parsing functions having SQL body with language sql (PG 15 feature) #2201

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
860e99a
Fix regex parser issue for parsing functions having SQL body with lan…
priyanshi-yb Jan 16, 2025
f4e04a9
cover other cases
priyanshi-yb Jan 21, 2025
80de2d6
remove print
priyanshi-yb Jan 21, 2025
ff7fb07
add more cases, and handle comment case in IsEndOFSqlStmt
priyanshi-yb Jan 21, 2025
6df033f
review comment
priyanshi-yb Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove print
  • Loading branch information
@priyanshi-yb
priyanshi-yb committed Jan 21, 2025
commit 80de2d6eb2bcf29c0c13a6902e11454f3674fcc8
1 change: 0 additions & 1 deletion yb-voyager/cmd/analyzeSchema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ end;`,
t.Errorf("Expected %d SQL statements for %s, got %d", len(expectedSqlInfoArr), objType, len(sqlInfoArr))
}

fmt.Printf("sqlinfoarr - %v", sqlInfoArr)
for i, expectedSqlInfo := range expectedSqlInfoArr {
assert.Equal(t, expectedSqlInfo.objName, sqlInfoArr[i].objName)
assert.Equal(t, expectedSqlInfo.stmt, sqlInfoArr[i].stmt)
Expand Down