Making changes in the airgapped script to remove gcc as a dependency. #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivanshGahlot
changed the title
ShivanshGahlot
requested review from
priyanshi-yb,
hbhanawat,
makalaaneesh,
sanyamsinghal and
shubham-yb
| @@ -685,6 +696,19 @@ ubuntu_main() { | |||
| # Call the install function with module details | |||
| install_perl_module "$module_name" "$requirement_type" "$required_version" "$package" | |||
| done | |||
| sudo dpkg -i ./libdbd-mysql-perl*.deb 1>&2 | |||
There was a problem hiding this comment.
for rhel, you also install something called mariadb-connector. Not required in ubuntu?
There was a problem hiding this comment.
Nope not required in this case. We tested it out.
| "libmysqlclient-dev|min|0" | ||
| "libmodule-build-perl|min|0" |
There was a problem hiding this comment.
was this also just a miss ? or it's required now and not before?
There was a problem hiding this comment.
Yeah this was not required earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Making changes in the airgapped script to remove gcc as a dependency.
Describe if there are any user-facing changes
Nope. Only a few dependencies were added and removed.
How was this pull request tested?
Manually
Does your PR have changes that can cause upgrade issues?