Implement Migration complexity using the assessment issues #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now the new algorithm for mig complexity considers all kind of issues including schema, query constructs, plpgsql, datatypes etc...
makalaaneesh
reviewed
Jan 8, 2025
| var ( | ||
| LEVEL_1_MEDIUM_THRESHOLD = 20 | ||
| LEVEL_1_HIGH_THRESHOLD = math.MaxInt32 | ||
| LEVEL_2_MEDIUM_THRESHOLD = 10 |
There was a problem hiding this comment.
not blocker: let's discuss these numbers once with everyone
There was a problem hiding this comment.
yeah sure, its already in the Functional Spec doc.
|
|
||
| // This is a temporary logic to get migration complexity for oracle based on the migration level from ora2pg report. | ||
| // Ideally, we should ALSO be considering the schema analysis report to get the migration complexity. | ||
| func calculateMigrationComplexityForOracle(schemaDirectory string) (string, error) { |
There was a problem hiding this comment.
assuming this is just a move
There was a problem hiding this comment.
yes, no change here
…rom LOW to MEDIUM - since the unsupported query constructs are being considered now in mig complexity calculatin
makalaaneesh
approved these changes
Jan 8, 2025
- complexity from Medium->High, and Low->Medium, due to new things - unsupported_datatype(level-3) and change in threshold for HIGH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Refer Gdoc for algorithm - https://docs.google.com/document/d/1HvjszZTlQ6fPG7GxpFgjWbq7o_H6bwqVsR4g9cy1mww/edit?tab=t.0
Describe if there are any user-facing changes
How was this pull request tested?
Added unit tests.
Existing end-to-end tests are enough(might need to update the expected complexity since logic has changed)
Does your PR have changes that can cause upgrade issues?