Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build tags to each test file #2116

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Adding build tags to each test file #2116

merged 2 commits into from
Dec 27, 2024

Conversation

sanyamsinghal
Copy link
Collaborator

@sanyamsinghal sanyamsinghal commented Dec 24, 2024

Describe the changes in this pull request

  • introduced three tags - unit, integration, issues_integration
  • every new test file added should have one of these tags
  • any test file without tag will be executed with each tag workflow

Describe if there are any user-facing changes

N/A

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

- introduced three tags - unit, integration, issues_integration
- every new test file added should have one of these tags
- any test file wihtout tag will be executed with each tag workflow
@sanyamsinghal sanyamsinghal self-assigned this Dec 24, 2024
@sanyamsinghal sanyamsinghal requested review from makalaaneesh and priyanshi-yb and removed request for makalaaneesh December 24, 2024 14:56
@sanyamsinghal sanyamsinghal marked this pull request as ready for review December 24, 2024 14:57
@priyanshi-yb
Copy link
Contributor

any test file wihtout tag will be executed with each tag workflow

Can you elaborate on this, I didn't get it what happens if a test file is added without tag?

@sanyamsinghal
Copy link
Collaborator Author

sanyamsinghal commented Dec 24, 2024

Can you elaborate on this, I didn't get it what happens if a test file is added without tag?

@priyanshi-yb

  1. go test -v ./.. -> go test files without tag
  2. go test -v ./... -tags='tag1' -> go test files with tag1 + files without tag
  3. go test -v ./... -tags='tag2' -> go test files with tag2 + files without tag

Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanyamsinghal sanyamsinghal merged commit bbfc84c into main Dec 27, 2024
43 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/build-tags branch December 27, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants