Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the logic for checking source db version compatibility and added it to assess migration too for PG #2115

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

ShivanshGahlot
Copy link
Collaborator

Describe the changes in this pull request

There was a bug in the logic for checking if source db version is compatibily in PG. Even with 16.2 source db version and max allowed version 16, it was failing. Fixed the logic to check only the major version.

Describe if there are any user-facing changes

None

How was this pull request tested?

Manually tested

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShivanshGahlot ShivanshGahlot merged commit 23033f8 into main Dec 24, 2024
42 checks passed
@ShivanshGahlot ShivanshGahlot deleted the shivansh/check-source-db-version-fix branch December 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants