Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed guardrail check for super user permission and the query for checking if schema exist in case of YB Aeon #2051

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

priyanshi-yb
Copy link
Contributor

@priyanshi-yb priyanshi-yb commented Dec 9, 2024

Describe the changes in this pull request

Fixing a few bugs with import schema and YB Aeon type of target db, the difference in behavior is because of yb_superuser with YB Aeon which has a subset of superuser's privileges.
issues are detailed in this ticket
https://yugabyte.atlassian.net/browse/DB-14398

Fixes - #2050

Describe if there are any user-facing changes

No

How was this pull request tested?

Manually with YB Aeon

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

… checking if schema exist in case of YB Aeon
@priyanshi-yb priyanshi-yb changed the title Fixed the guradrail check for super user permission and the query for checking if schema exist in case of YB Aeon Fixed guardrail check for super user permission and the query for checking if schema exist in case of YB Aeon Dec 9, 2024
@priyanshi-yb priyanshi-yb marked this pull request as ready for review December 10, 2024 07:34
yb-voyager/src/tgtdb/yugabytedb.go Show resolved Hide resolved
yb-voyager/src/tgtdb/yugabytedb.go Show resolved Hide resolved
yb-voyager/src/tgtdb/yugabytedb.go Show resolved Hide resolved
yb-voyager/src/tgtdb/yugabytedb.go Show resolved Hide resolved
Copy link
Collaborator

@ShivanshGahlot ShivanshGahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@priyanshi-yb priyanshi-yb merged commit 5fec48b into main Dec 13, 2024
42 checks passed
@priyanshi-yb priyanshi-yb deleted the priyanshi/fix-ybmcases branch December 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants