Also consider memory usage in adaptive parallelism #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanyamsinghal
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Any of the metadata scripts are not modified so the tar should remain unchanged.
There was a problem hiding this comment.
Got committed because of the commit hook :) I've merged main and re-generated the tar, so should be fine
Comment on lines
+34
to
+42
| memAvailable1 int | ||
| memTotal1 int | ||
| tserverRootMemConsumption1 int | ||
| tserverRootMemSoftLimit1 int | ||
|
|
||
| memAvailable2 int | ||
| memTotal2 int | ||
| tserverRootMemConsumption2 int | ||
| tserverRootMemSoftLimit2 int |
There was a problem hiding this comment.
Q. Is all this info also available in the dbside function you have implemented?
There was a problem hiding this comment.
Yes, yugabyte/yugabyte-db@872b59e .
Also added a comment in code with this sample output
|
@makalaaneesh please make the final commit message descriptive enough, before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consider memory load while adapting parallelism.
Memory load is considered to be high in the following scenarios
When memory load is high, we decrease the parallelism by 1 (similar to when cpu load is high)