Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
priyanshi-yb committed Dec 20, 2024
1 parent 2348e26 commit 3700e44
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion yb-voyager/src/query/queryissue/detectors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ WHERE title = 'Design Document';`,

issues := getDetectorIssues(t, NewFuncCallDetector(sql), sql)
assert.Equal(t, 1, len(issues), "Expected 1 issue for SQL: %s", sql)
assert.Equal(t, AGGREGATE_FUNCTION, issues[0].Type, "Expected Advisory Locks issue for SQL: %s", sql)
assert.Equal(t, ADVISORY_LOCKS, issues[0].Type, "Expected Advisory Locks issue for SQL: %s", sql)
}

for _, sql := range loFunctionSqls {
Expand Down
2 changes: 1 addition & 1 deletion yb-voyager/src/query/queryissue/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ var unsupportedAggFunctions = mapset.NewThreadUnsafeSet([]string{
}...)

const (
// These functions are not func call node, they are separate node types, "json_objectagg", "json_array", "json_arrayagg"
// // json functions, refer - https://www.postgresql.org/about/featurematrix/detail/395/
JSON_OBJECTAGG = "JSON_OBJECTAGG"
JSON_ARRAY = "JSON_ARRAY"
JSON_ARRAYAGG = "JSON_ARRAYAGG"
Expand Down

0 comments on commit 3700e44

Please sign in to comment.