[DBZ-PGYB] Bug fix to use correct getter for maximum retries #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test plan. I believe adding a UT might not be feasible here, but can you describe the manual testing performed to validate the changes. |
Sumukh-Phalgaonkar
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a method by overriding it in
PostgresConnectorConfigclass to use the value we have defined as our maximum retry count. Currently, the code uses the value defined in the base class which defaults to the the connector going for unlimited retries.Testing
Ran some manual tests where I simulated failures by bringing down the YB cluster and observing that the logs are indicating a finite number of retries instead of unlimited retries.