[DBZ-PGYB][yugabyte/yugabyte-db#24200] Execute snapshot in chunks #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-yb
commented
Sep 27, 2024
...stgres/src/main/java/io/debezium/connector/postgresql/PostgresSnapshotChangeEventSource.java
Outdated
Show resolved
Hide resolved
vaibhav-yb
commented
Sep 27, 2024
debezium-core/src/main/java/io/debezium/relational/RelationalSnapshotChangeEventSource.java
Outdated
Show resolved
Hide resolved
vaibhav-yb
commented
Sep 27, 2024
...nnector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
Show resolved
Hide resolved
Sumukh-Phalgaonkar
requested changes
Oct 17, 2024
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
|
Also could you add some unit tests for this:
|
|
In the run with custom image it was observed that the task-id was not getting printed in the snapshot logs. Can it be added to those logs or will it require larger effort? |
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
...m-connector-postgres/src/main/java/io/debezium/connector/postgresql/YugabyteDBConnector.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| protected String getQueryForParallelSnapshotSelect(long lowerBound, long upperBound) { | ||
| return String.format("SELECT * FROM %s WHERE yb_hash_code(%s) >= %d AND yb_hash_code(%s) <= %s", |
There was a problem hiding this comment.
What will happen if a user only has range partitioned primary key and the parallel snapshot mode is deployed. What if the primary key is a composite like (id HASH, v1 ASC)? Will this still work or should we add another validation that only hash partitioned columns should be provided in primary.keys field?
vaibhav-yb
changed the title
siddharth2411
requested changes
Oct 17, 2024
| .withDisplayName("Comma separated primary key fields") | ||
| .withType(Type.STRING) | ||
| .withImportance(Importance.LOW) | ||
| .withDescription("A comma separated value having all the primary key components") |
There was a problem hiding this comment.
Should we update this description to say HASH components of the primary key?
| // Perform basic validations. | ||
| validateSingleTableProvidedForParallelSnapshot(tableIncludeList); | ||
|
|
||
| // Publication auto create mode should not be for all tables. |
There was a problem hiding this comment.
Can also move this into a separate function - validatePublicationForParallelSnapshot
| taskProps.put(PostgresConnectorConfig.TASK_ID.name(), String.valueOf(i)); | ||
|
|
||
| long lowerBound = i * rangeSize; | ||
| long upperBound = (i == maxTasks - 1) ? upperBoundExclusive - 1 : (lowerBound + rangeSize - 1); |
There was a problem hiding this comment.
Can add a comment explaining this special handling for the last task.
| @@ -1116,6 +1116,46 @@ public void shouldHaveBeforeImageOfUpdatedRow() throws InterruptedException { | |||
| assertThat(updateRecordValue.getStruct(Envelope.FieldName.AFTER).getStruct("aa").getInt32("value")).isEqualTo(404); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you add a test for primary.keys config?
Sumukh-Phalgaonkar
approved these changes
Oct 17, 2024
siddharth2411
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For very large tables, the default
SELECT *query can take a really long time to complete leading to longer time for snapshots.Solution
This PR aims to implement snapshotting the table in parallel using an inbuilt method
yb_hash_codeto only run the query for a given hash range. The following 2 configuration properties are introduced with this PR:snapshot.modecalledparallel- this will behave exactly likeinitial_onlybut we will have the ability to launch multiple tasks.primary.key.hash.columns- this config takes in a comma separated values of the primary key hash component of the table.