forked from debezium/debezium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore tables without a valid pgschema_name value #15
Merged
vaibhav-yb
merged 14 commits into
yugabyte:final-connector-ybdb
from
vaibhav-yb:fix-to-ignore-older-tables
Apr 11, 2022
Merged
Ignore tables without a valid pgschema_name value #15
vaibhav-yb
merged 14 commits into
yugabyte:final-connector-ybdb
from
vaibhav-yb:fix-to-ignore-older-tables
Apr 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suranjan
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of the comment.
...onnector-yugabytedb2/src/main/java/io/debezium/connector/yugabytedb/YugabyteDBConnector.java
Show resolved
Hide resolved
...onnector-yugabytedb2/src/main/java/io/debezium/connector/yugabytedb/YugabyteDBConnector.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user creates a table
old_table
with an older version of YugabyteDB, let's say 2.11 and upgrades to a version with the CDCSDK changes, then theold_table
would not have the metadata in itsTableInfo
which has thepgschema_name
value. This in turn causes a regression in Debezium connector since it utilizes the schema name to parse the name of the tables, so after upgrade, while filtering the tables, ifpgschema_name
value is not found in any of the tables, the Debezium connector for YugabyteDB throws aNullPointerException
.This PR addresses the issue and adds the logic to ignore the tables which do not have a
pgschema_name
value, consequently meaning that the connector is ignoring the tables created using the older versions of YugabyteDB.Steps to test:
old_table
with YugabyteDB version 2.11 on platformnew_table
new_table