[DBZ-PGYB] Changes to support all operations with all replica identities #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumukh-Phalgaonkar
requested changes
Jun 5, 2024
...-postgres/src/main/java/io/debezium/connector/postgresql/connection/ReplicaIdentityInfo.java
Show resolved
Hide resolved
...tor-postgres/src/main/java/io/debezium/connector/postgresql/PostgresChangeRecordEmitter.java
Show resolved
Hide resolved
...ector-postgres/src/test/java/io/debezium/connector/postgresql/YugabyteReplicaIdentityIT.java
Show resolved
Hide resolved
...ector-postgres/src/test/java/io/debezium/connector/postgresql/YugabyteReplicaIdentityIT.java
Show resolved
Hide resolved
...ector-postgres/src/test/java/io/debezium/connector/postgresql/YugabyteReplicaIdentityIT.java
Show resolved
Hide resolved
...ector-postgres/src/test/java/io/debezium/connector/postgresql/YugabyteReplicaIdentityIT.java
Show resolved
Hide resolved
suranjan
approved these changes
Jun 11, 2024
...tgres/src/main/java/io/debezium/connector/postgresql/PostgresStreamingChangeEventSource.java
Outdated
Show resolved
Hide resolved
Sumukh-Phalgaonkar
approved these changes
Jun 12, 2024
vaibhav-yb
changed the base branch from
ybdb-debezium-252-vaibhav
to
ybdb-debezium-2.5.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the changes to the connector required to support all kinds of operations supported by YugabyteDB when coupled with various replica identities.
One change to note here would be that in case of
DEFUALTreplica identity, Postgres sends out the before image of the primary key column in case ofDELETEandUPDATEoperations. Meanwhile, YugabyteDB only sends out the before image of primary key in case ofDELETEoperations, and if a primary key itself is updated, YugabyteDB sends two events:Additionally to test out everything, we have a new test class
YugabyteReplicaIdentityIT.