Make Output#version return a Time object #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertcheramy
added a commit
to ytti/oxidized-web
that referenced
this pull request
Mar 17, 2025
- Needs ytti/oxidized#3462 to be released in a new oxidized version - TODOs: - remove any reference to :date and passing the date as a string. - update the gem dependency to the new oxidized version
robertcheramy
added a commit
to ytti/oxidized-web
that referenced
this pull request
Mar 17, 2025
- Needs ytti/oxidized#3462 to be released in a new oxidized version - TODOs: - remove any reference to :date and passing the date as a string. - update the gem dependency to the new oxidized version
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
This PR contains modifications needed in order to resolve ytti/oxidized-web#258 .
It returns the time of a commit as a Time object (hash key
:time), in order not having to reconvert a String ( hash key:date) back into a Time object later.The hash key
datecannot be removed for now, this has to happen after new versions of oxidized and oxidized-web have been released.