-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ORF] Extractor overhaul #32802
[ORF] Extractor overhaul #32802
Conversation
* skip reason can't be unicode in Py2 * remove duplicate assert...Equal functions
* add `ORFONIE`, back-porting yt-dlp PR yt-dlp/yt-dlp#9113 and friends: thx HobbyistDev, TuxCoder, seproDev * re-factor to support livestreams via new `ORFONliveIE`
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
* fix getting media via DASH instead of inaccessible mp4 * also get in-page YT media
JFTR, I've tested 0153b38. Both URLs,
Note, the links are (should be) available for 30 days from within Austria. |
JFTR, I did another test and tried to download the following URL https://on.orf.at/video/14236058/olympische-spiele-paris-2024-die-eroeffnung.
It seems to work, but I noticed that the I got the "second" audio stream (Audio description, (AD)), instead of the main audio stream. Not sure why. If it helps, this is what I got after everything was downloaded:
|
Boilerplate: own/yt-dlp code, fix/new extractor
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR overhauls and brings up-to-date the ORF extractor module.
TV is now handled by the on.orf.at single-page-app, replacing the former TVthek. The PR back-ports the
ORFONIE
recently added to yt-dlp to replace the brokenORFTVthekIE
: thx @HobbyistDev, @TuxCoder, @seproDev. Resolves #32798.Some shows (former extended live events?) may be returned as
multi_video
playlists: yt-dl has no support for automatic concatenation ofmulti_video
playlists (yet), but if the same format is selected for all items (segments) it should be possible to concatenate the A-V streams without re-encoding using ffmpeg.Livestream support (not widely tested) has been added. See also yt-dlp/yt-dlp#10052.
Similarly radio and audio clips are now handled through sound.orf.at. The
ORFRadioIE
extractor has been updated and made public to support this as well as residual xx.orf.at/player/... URLs. The previous per-station IEs are removed. Resolves #29394. See also yt-dlp/yt-dlp#5265, yt-dlp/yt-dlp#9581.ORFRadioCollectionIE
is added to support playlists in ORF Sound.The PR also back-ports and re-works
ORFPodcastIE
from yt-dlp: thx @Esokrates.ORFFM4StoryIE
is fixed and also now gets any in-page YT media: see yt-dlp/yt-dlp#2477.Core
YoutubeDL
processing is tweaked to support some not previously encountered playlist structures.