Resolve audio/x-wav to "wav" extension, rather than "x-wav" (which ffmpeg does not recognize) #26463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25938 Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This fixes ffmpeg errors when trying to downloading certain audio files from Soundcloud with the --add-metadata option set. I believe these files were uploaded without an extension, and are being identified as audio/x-wav. However, youtube-dl was downloading them with a "x-wav" extension, which ffmpeg fails to recognize as a valid output format. This change forces the extension to be "wav" which resolves the issue.
An example to reproduce the problem:
Before this change:
After this change: