Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: hotfix linting issue #4450

Merged
merged 1 commit into from
May 22, 2023
Merged

STY: hotfix linting issue #4450

merged 1 commit into from
May 22, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

resolves a silent conflict from merging #4444 and #4439 in that order

@neutrinoceros neutrinoceros added blocker Highest priority level code style Related to linting tools labels May 22, 2023
@neutrinoceros neutrinoceros added this to the 4.2.0 milestone May 22, 2023
matthewturk
matthewturk approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly it's fine for this to go in, but I'm pretty ... blase ... about whether this is an improvement or just a change. Thank you for addressing the conflicts for those two PRs!

@neutrinoceros neutrinoceros enabled auto-merge May 22, 2023 16:34
@neutrinoceros neutrinoceros merged commit 4a3c266 into yt-project:main May 22, 2023
@neutrinoceros neutrinoceros deleted the hotfix_linting branch May 22, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
blocker Highest priority level bug code style Related to linting tools
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk