DEPR: do not try to predict removal dates in deprecation warnings by default #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
deprecation
neutrinoceros
force-pushed
the
no_predictions_in_depr_messages
branch
from
c00a823 to
8c2ee96
Compare
chrishavlin
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A hard-learned lesson from yt 4.1 was that making promises about when deprecated features would be removed can sometimes come back at us and make releases much more difficult to polish.
In most recent feature releases (4.0, 4.1, and soon 4.2), we made some eager cuts through stuff that was deprecated in the previous 7 or so years, but long term it's probably better to just not try to anticipate too accurately when deprecated code is actually going to be removed, and we can probably just live with it as long as it doesn't impede further developments.