Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SbSystemGetLocaleIdTest.SunnyDay filter #4950

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove SbSystemGetLocaleIdTest.SunnyDay filter #4950

wants to merge 1 commit into from

Conversation

hlwarriner
Copy link
Contributor

b/398231119

@hlwarriner hlwarriner marked this pull request as draft February 21, 2025 17:53
@hlwarriner hlwarriner added on_device runtest Trigger presubmit workflows. labels Feb 21, 2025
@yell0wd0g
Copy link
Contributor

N.B. Test is failing on Linux with


2025-02-21T18:34:47.8805061Z [ RUN      ] SbSystemGetLocaleIdTest.SunnyDay
2025-02-21T18:34:47.8805204Z ../../starboard/nplb/system_get_locale_id_test.cc:25: Failure
2025-02-21T18:34:47.8805319Z Expected: (kNull) != (locale), actual: NULL vs NULL
2025-02-21T18:34:47.8805404Z Stack trace:
2025-02-21T18:34:47.8805727Z #0 0x555b46be33d9 starboard::nplb::(anonymous namespace)::SbSystemGetLocaleIdTest_SunnyDay_Test::TestBody()
2025-02-21T18:34:47.8805734Z 
2025-02-21T18:34:47.8805868Z [  FAILED  ] SbSystemGetLocaleIdTest.SunnyDay (4 ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on_device runtest Trigger presubmit workflows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hlwarriner @yell0wd0g