Reland "Add VideoGeometrySetter Service for Cobalt (#4810)" #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
android_dcheck_v2
branch
2 times, most recently
from
78a1e9d to
d165e88
Compare
yell0wd0g
approved these changes
Feb 18, 2025
This is a reland of 10d4851 This CL fixed DCHECK failed caused by the PR (youtube#4810) and list the fixes below (b/397413189): - Removed `DCHECK(content::RenderThread::IsMainThread());` in CobaltContentRendererClient due to CobaltContentRendererClient is not in Render Thread. - Moved the order of `DCHECK(video_geometry_change_subcriber_remote_);` after `video_geometry_setter_service_->GetVideoGeometryChangeSubscriber` in StarboardRenderer. - Changed `gfx::ToNearestRect()` to `gfx::ToEnclosingRect()` in StarboardRenderer. Original change's description: > Add VideoGeometrySetter Service for Cobalt (youtube#4810) > > StarboardRender needs to be informed with the video geometry information > from the display compositor. VideoGeometrySetter provides the IPC > between the StarobardRenderer and the display compositor so the video > geometry information can reach StarboardRenderer. > > This refers to > https://chromium-review.googlesource.com/c/chromium/src/+/1799692 with > the following modifications: > - VideoGeometrySetterService is in Renderer thread, and it is exposed to > ContentBrowserClient. > - ContentBrowserClient binds VideoGeometrySetterService after receiving > mojo::PendingRemote\<cobalt::media::mojom::VideoGeometrySetter\> from > compositing thread (viz) to Renderer thread. > - ContentRendererClient creates a custom StarboardRendererFactory, which > allows to bind |overlay_plane_id| for each StarboardRenderer with > VideoGeometrySetterService. > > This CL also cleans up the old implementations for setting video bounds: > youtube#4385, because it is unnecessary > with this PR. > > b/391938746
borongc
force-pushed
the
android_dcheck_v2
branch
from
d165e88 to
464300d
Compare
jasonzhangxx
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of 10d4851
This CL fixed DCHECK failed caused by the PR (#4810) and list the fixes below (b/397413189):
DCHECK(content::RenderThread::IsMainThread());in CobaltContentRendererClient due to CobaltContentRendererClient is not in Render Thread.DCHECK(video_geometry_change_subcriber_remote_);aftervideo_geometry_setter_service_->GetVideoGeometryChangeSubscriberin StarboardRenderer.gfx::ToNearestRect()togfx::ToEnclosingRect()in StarboardRenderer.Original change's description: