[Ozone] Disable all non-starboard backends #4828
Conversation
|
@y4vor @madhurajayaraman When either of you have time can you confirm this works for you as well? You may need to regenerate your args.gn using |
TyHolc
force-pushed
the
disable_ozone_backends
branch
from
29ffb5e to
42e3383
Compare
TyHolc
force-pushed
the
disable_ozone_backends
branch
from
d4270da to
f5e72b9
Compare
TyHolc
force-pushed
the
disable_ozone_backends
branch
6 times, most recently
from
fcc1ad2 to
e3ea38a
Compare
Cobalt will only use Starboard as an Ozone backend. Disable all non-starboard backends and avoid compiling them. b/393422551
Change EGL call for getting a display to allow attributes to be set and passed. Match these attributes to the ones that are set by the Cobalt binary in ui/gl/gl_display.cc so we're sure that we're testing the correct behavior. b/393422551
b/393422551
TyHolc
force-pushed
the
disable_ozone_backends
branch
from
e3ea38a to
62d31bf
Compare
| @@ -174,7 +185,9 @@ void FakeGraphicsContextProvider::InitializeWindow() { | |||
| } | |||
|
|
|||
| void FakeGraphicsContextProvider::InitializeEGL() { | |||
| display_ = EGL_CALL_SIMPLE(eglGetDisplay(EGL_DEFAULT_DISPLAY)); | |||
| display_ = EGL_CALL_SIMPLE(eglGetPlatformDisplay( | |||
| EGL_PLATFORM_ANGLE_ANGLE, reinterpret_cast<void*>(SB_EGL_DEFAULT_DISPLAY), | |||
There was a problem hiding this comment.
Just a thought that this call (eglGetPlatformDisplay() with this EGL_PLATFORM_ANGLE_ANGLE parameter) is supported as an extension (https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/extensions/EGL_ANGLE_platform_angle.txt;l=63-65 which may or may not be supported by the platform.
This code (https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/libANGLE/validationEGL.cpp;l=783-826;drc=883f6246c6bdd5751eb78f48b6c365158b23c3a2) might help figuring out other combinations?
Cobalt will only use Starboard as an Ozone backend. Disable all non-starboard backends and avoid compiling them.
b/393422551