Skip to content

Commit

Permalink
Update the comment of SbPlayerGetInfo() (#4713)
Browse files Browse the repository at this point in the history
Update the comment to explicitly mention SbPlayerGetInfo() can be called
from arbitrary threads.

b/390259519
  • Loading branch information
jasonzhangxx authored Jan 21, 2025
1 parent 73018f4 commit d78bb51
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions starboard/player.h
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,6 @@ static inline bool SbPlayerIsValid(SbPlayer player) {
// - The associated decoder of the returned player should be assumed to not be
// in |kSbPlayerDecoderStateNeedsData| until SbPlayerSeek() has been called
// on it.
// - It is expected either that the thread that calls SbPlayerCreate is the same
// thread that calls the other |SbPlayer| functions for that player, or that
// there is a mutex guarding calls into each |SbPlayer| instance.
// - If there is a platform limitation on how many players can coexist
// simultaneously, then calls made to this function that attempt to exceed
// that limit must return |kSbPlayerInvalid|. Multiple calls to SbPlayerCreate
Expand Down Expand Up @@ -585,8 +582,8 @@ SB_EXPORT bool SbPlayerSetPlaybackRate(SbPlayer player, double playback_rate);
SB_EXPORT void SbPlayerSetVolume(SbPlayer player, double volume);

// Gets a snapshot of the current player state and writes it to
// |out_player_info|. This function may be called very frequently and is
// expected to be inexpensive.
// |out_player_info|. This function may be called very frequently from arbitrary
// threads and is expected to be inexpensive and thread safe.
//
// |player|: The player about which information is being retrieved. Must not be
// |kSbPlayerInvalid|.
Expand Down

0 comments on commit d78bb51

Please sign in to comment.