-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#18] HandyDivider 생성 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeJoEun-01
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오! 빠르게 잘해주셨네요!! 수고하셨습니다~
[#13] HandyFab 생성
LeeJoEun-01
added a commit
that referenced
this pull request
Nov 9, 2024
* [#19] Switch 코드 변경 * Chip * [#8] chipViewController 생성 * [#8] ViewDidLoad 삭제 * [#8] SnapKit으로 정리, icon추가 * [#8] icon추가, 주석 정리 * [#8] icon 색상 지정 * ChipViewController SnapKit 문법 수정 * [#8] rebase conflict 및 package 에러 해결 * [#18] HandyDivider 생성 (#22) * [#13] HandyFab 생성 * [#18] HandyDivider 생성 * [#13] 1차 코드 리뷰 반영 * [#18] 불필요 height, Vertical Divider 삭제 * Chip * [#8] chipViewController 생성 * [#8] ViewDidLoad 삭제 * [#8] SnapKit으로 정리, icon추가 * [#8] icon추가, 주석 정리 * [#8] icon 색상 지정 * ChipViewController SnapKit 문법 수정 * [#8] rebase conflict 및 package 에러 해결 * [#18] HandyDivider 생성 * [#18] 불필요 height, Vertical Divider 삭제 * [#18] rebase conflict 해결 * [#18] package.resolved 업로드 --------- Co-authored-by: wjdalswl <[email protected]> Co-authored-by: LeeJoEun-01 <[email protected]> * [#6] HandyCheckBox 생성 * [#6] HandyCheckBox 테스트 추가 * [#6] checkBox ConfigurationButton으로 변경 * [#6] HandyRadioButton 추가 * [#6] HandyCheckBox 생성 * [#6] testViewController 수정 * [#6] checkBox, radioButton tintColor 커스텀 추가 * [#6]NON_ISSUE conflict resolve * [#19] Switch 코드 변경 * [#19] 코드리뷰 반영 * [#24] Snackbar Info 타입 제작 * [#24] Handy 기본 아이콘 24개 추가 * [#24] Snackbar Error 타입 제작 * [#24] Radius 단위 CGFloat로 변환 * [#24] Error 타입 레이아웃 수정 및 버튼 액션 추가 * [#24] Snackbar Swipe Gesture 추가 * [#24] 코드리뷰 반영 * [#24] 코드리뷰 반영 2 * [#19] Switch 코드 변경 * [#19] 코드리뷰 반영 --------- Co-authored-by: jysuhr <[email protected]> Co-authored-by: jysuhr <[email protected]> Co-authored-by: wjdalswl <[email protected]> Co-authored-by: hyeonju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
✍️ Description
💡 PR Point
Divider의 height를 설정하지 않아도 되도록 했습니다.
📚 Reference
🔥 Test
사용방법