Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#18] HandyDivider 생성 #22

Merged
merged 19 commits into from
Oct 9, 2024
Merged

[#18] HandyDivider 생성 #22

merged 19 commits into from
Oct 9, 2024

Conversation

jysuhr
Copy link
Contributor

@jysuhr jysuhr commented Sep 23, 2024

📌 Summary

  • Divider 두께 (1, 2, 4, 8)
  • Divider 너비 설정 가능

✍️ Description

💡 PR Point

Divider의 height를 설정하지 않아도 되도록 했습니다.

📚 Reference

🔥 Test

스크린샷 2024-09-23 오후 9 06 37

사용방법

let divider1: HandyDivider = {
    let divider = HandyDivider()
    divider.thickness = .thickness1
    return divider
}()

@jysuhr jysuhr added the feat 💜 새로운 기능 구현 label Sep 23, 2024
@jysuhr jysuhr self-assigned this Sep 23, 2024
Copy link
Contributor

@LeeJoEun-01 LeeJoEun-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오! 빠르게 잘해주셨네요!! 수고하셨습니다~

@LeeJoEun-01 LeeJoEun-01 merged commit 7cf0deb into main Oct 9, 2024
@LeeJoEun-01 LeeJoEun-01 deleted the feature/#18 branch October 9, 2024 01:43
LeeJoEun-01 added a commit that referenced this pull request Nov 9, 2024
* [#19] Switch 코드 변경

* Chip

* [#8] chipViewController 생성

* [#8] ViewDidLoad 삭제

* [#8] SnapKit으로 정리, icon추가

* [#8] icon추가,  주석 정리

* [#8] icon 색상 지정

* ChipViewController SnapKit 문법 수정

* [#8] rebase conflict 및 package 에러 해결

* [#18] HandyDivider 생성 (#22)

* [#13] HandyFab 생성

* [#18] HandyDivider 생성

* [#13] 1차 코드 리뷰 반영

* [#18] 불필요 height, Vertical Divider 삭제

* Chip

* [#8] chipViewController 생성

* [#8] ViewDidLoad 삭제

* [#8] SnapKit으로 정리, icon추가

* [#8] icon추가,  주석 정리

* [#8] icon 색상 지정

* ChipViewController SnapKit 문법 수정

* [#8] rebase conflict 및 package 에러 해결

* [#18] HandyDivider 생성

* [#18] 불필요 height, Vertical Divider 삭제

* [#18] rebase conflict 해결

* [#18] package.resolved 업로드

---------

Co-authored-by: wjdalswl <[email protected]>
Co-authored-by: LeeJoEun-01 <[email protected]>

* [#6] HandyCheckBox 생성

* [#6] HandyCheckBox 테스트 추가

* [#6] checkBox ConfigurationButton으로 변경

* [#6] HandyRadioButton 추가

* [#6] HandyCheckBox 생성

* [#6] testViewController 수정

* [#6] checkBox, radioButton tintColor 커스텀 추가

* [#6]NON_ISSUE conflict resolve

* [#19] Switch 코드 변경

* [#19] 코드리뷰 반영

* [#24] Snackbar Info 타입 제작

* [#24] Handy 기본 아이콘 24개 추가

* [#24] Snackbar Error 타입 제작

* [#24] Radius 단위 CGFloat로 변환

* [#24] Error 타입 레이아웃 수정 및 버튼 액션 추가

* [#24] Snackbar Swipe Gesture 추가

* [#24] 코드리뷰 반영

* [#24] 코드리뷰 반영 2

* [#19] Switch 코드 변경

* [#19] 코드리뷰 반영

---------

Co-authored-by: jysuhr <[email protected]>
Co-authored-by: jysuhr <[email protected]>
Co-authored-by: wjdalswl <[email protected]>
Co-authored-by: hyeonju <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 💜 새로운 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants