Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handy primitive color token 구현 #123

Closed
wants to merge 1 commit into from

Conversation

2wndrhs
Copy link
Member

@2wndrhs 2wndrhs commented Jul 11, 2024

1️⃣ 어떤 작업을 했나요? (Summary)

기존 코드에 영향을 미치지 않는 변경사항

기존 YDS에서 사용하던 baseColor들을 삭제하고 Handy Design System에서 새로 정의된 primitiveColor를 추가하였습니다.

image

2️⃣ 알아두시면 좋아요!

현스가 타입을 잘 선언해둬서 수정하기 너무 편했네요 완전 짱이다..

3️⃣ 추후 작업

  • PR 리뷰 기반 수정

4️⃣ 체크리스트 (Checklist)

  • main 브랜치의 최신 코드를 pull 받았나요?

@2wndrhs 2wndrhs added the feat label Jul 11, 2024
@2wndrhs 2wndrhs self-assigned this Jul 11, 2024
@2wndrhs 2wndrhs requested review from nijuy and fecapark as code owners July 11, 2024 13:40
@2wndrhs 2wndrhs changed the title feat: primitive color token 구현 feat: handy primitive color token 구현 Jul 11, 2024
@2wndrhs 2wndrhs closed this Jul 11, 2024
@2wndrhs 2wndrhs deleted the feat/#122-handy-primitive-color branch July 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Handy Primitive Token 추가
1 participant