New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divider color token 변경 #31

Open

kangyuri1114 wants to merge 3 commits into main from feature/rein/fix-divider-token-naming

Member

kangyuri1114 commented Jan 31, 2025

변경된 Divider 토큰명에 따라 Divider color의 default color 값을 lineBasicStrong으로 수정했습니다.

한가지 고민되는 건 Divider도 그렇고 다른 컴포넌트들도 Color 지정이 너무 열려있는 건 아닌가 싶습니다.
material처럼 각 컴포넌트에 대한 컬러 객체를 만드는 게 어떨지 고민이 되네요..
이렇게 되면 컬러 커스텀이 또 까다로워지긴 할거라 고민입니다

kangyuri1114 added 3 commits

January 31, 2025 15:12


          feat: SemanticColors 주석 명칭 수정 및 color 추가 Outlined -> Line

8a36001


          feat: divider color default 값 수정(bgBasicStrong -> lineBasicStrong)

9574e57


          feat: divider priview color 값 수정

kangyuri1114 self-assigned this

kangyuri1114 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels