Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase regex version constraint compatibility #234

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Oct 2, 2024

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

The current version constraint causes issues, specifying a dependency of 1 indicates compatibility with any other 1.*.* version of the regex crate, which I think is the case here.

This is related to discussion in #190 (comment)

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Thanks!

Does this PR introduce a user-facing change?

None

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.02%. Comparing base (57570dd) to head (957503c).
Report is 58 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   26.61%   29.02%   +2.41%     
==========================================
  Files          24       26       +2     
  Lines        2788     3159     +371     
  Branches     1516     1671     +155     
==========================================
+ Hits          742      917     +175     
- Misses        948     1021      +73     
- Partials     1098     1221     +123     

@saschagrunert
Copy link
Contributor

@kpcyrd do you mind a rebase?

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Oct 7, 2024

Done!

@utam0k utam0k merged commit daef608 into youki-dev:main Oct 8, 2024
13 checks passed
@kpcyrd kpcyrd deleted the regex-1 branch October 8, 2024 08:18
@kpcyrd
Copy link
Contributor Author

kpcyrd commented Nov 10, 2024

Could you please release a new version? :) the latest version on crates.io still breaks cargo outdated -R for my project.

@saschagrunert saschagrunert mentioned this pull request Nov 11, 2024
@saschagrunert
Copy link
Contributor

Could you please release a new version? :) the latest version on crates.io still breaks cargo outdated -R for my project.

Yeah: #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants