Add missing rename attribute to LinuxSyscall (fixes clone3 problems)
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dustin Martin <[email protected]>
dmartin
force-pushed
the
linuxsyscall-rename
branch
from
0afd110 to
1595d7a
Compare
saschagrunert
approved these changes
Feb 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 23.98% 23.98%
=======================================
Files 21 21
Lines 1622 1622
Branches 809 809
=======================================
Hits 389 389
Misses 541 541
Partials 692 692 |
This was referenced Jun 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinuxSyscallwas missing this rename attribute, so theerrnoRetfield was not being handled properly.This might have gone unnoticed as the default moby seccomp profile has only one non-default errnoRet value for
clone3, but unfortunately it causes a lot of issues when it's missing (moby/moby#42681, https://stackoverflow.com/questions/71941032/why-i-cannot-run-apt-update-inside-a-fresh-ubuntu22-04)