Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-506: ui-vue3 > Add ability to clear date picker #425

Merged
merged 1 commit into from
Nov 19, 2024
Merged

UI-506: ui-vue3 > Add ability to clear date picker #425

merged 1 commit into from
Nov 19, 2024

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Nov 19, 2024 •
edited
Loading

JIRA Ticket

UI-506

QA Steps

Note

The github actions below are for alto, this PR introduces a fix in ui-vue3 :sadge: so you'd have to QA it manually

  • cd into packages/vue3
  • run pnpm dev
  • a browser window should open and you should see storybook
  • look for Date / Single and Date / Range
  • test them both out by specifying a date, when you do you should notice an "X" button next to the calendar icon
  • Click on the "X" button
  • The date value should be cleared
Screen.Recording.2024-11-19.at.2.37.23.PM.mov
Screen.Recording.2024-11-19.at.2.37.01.PM.mov

Note

Leave empty when you have nothing to say

@eihabkhan eihabkhan self-assigned this Nov 19, 2024
@eihabkhan eihabkhan added the ⏳ in progress Still in development phase. label Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

🔍 Visual review for your branch is published 🔍

Here are the links to:

@eihabkhan eihabkhan added 💻 Ready for review Requires a review from another developer. and removed ⏳ in progress Still in development phase. labels Nov 19, 2024
@eihabkhan eihabkhan merged commit ab649f9 into main Nov 19, 2024
6 checks passed
@eihabkhan eihabkhan deleted the UI-506 branch November 19, 2024 14:37
@eihabkhan eihabkhan added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azuradara azuradara azuradara approved these changes

Assignees

@eihabkhan eihabkhan

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan @azuradara