Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI-329 : integrating tests with storybook #337

Merged
merged 23 commits into from
May 27, 2024
Merged

UI-329 : integrating tests with storybook #337

merged 23 commits into from
May 27, 2024

Conversation

GhitaNektt
Copy link
Contributor

@GhitaNektt GhitaNektt commented May 10, 2024 •
edited by mosarabi
Loading

JIRA Ticket

UI-329

QA Steps

  • RTL
  • Responsiveness
  • Class Names (insure specificity)
  • Build (No errors)

Note

Leave empty when you have nothing to say

@GhitaNektt GhitaNektt added the ⏳ in progress Still in development phase. label May 10, 2024
@GhitaNektt GhitaNektt self-assigned this May 10, 2024
@GhitaNektt GhitaNektt added 💻 Ready for review Requires a review from another developer. and removed ⏳ in progress Still in development phase. labels May 13, 2024
@mosarabi
Copy link
Contributor

mosarabi commented May 20, 2024 •
edited
Loading

when running pnpm test-storybook command

Screenshot 2024-05-20 at 17 02 43

@GhitaNektt GhitaNektt added ✅ Reviewed PR has been reviewed and approved. and removed 💻 Ready for review Requires a review from another developer. labels May 27, 2024
@GhitaNektt GhitaNektt merged commit c338ec9 into Phoenix May 27, 2024
3 checks passed
@GhitaNektt GhitaNektt deleted the UI-329 branch May 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosarabi mosarabi mosarabi approved these changes

@AliHMIMS AliHMIMS Awaiting requested review from AliHMIMS AliHMIMS is a code owner

@eihabkhan eihabkhan Awaiting requested review from eihabkhan

Assignees

@GhitaNektt GhitaNektt

Labels
✅ Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhitaNektt @mosarabi