Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Yorkie Helm Charts #513

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Update Yorkie Helm Charts #513

merged 5 commits into from
Apr 17, 2023

Conversation

krapie
Copy link
Member

@krapie krapie commented Apr 17, 2023

What this PR does / why we need it:

Update Yorkie Helm Charts.

This updates contains:

  • Use Istio Operator to safely install Istio in yorkie-cluster helm chart.
  • Include Loki Logging system in yorkie-monitoring helm chart.
  • Change ArgoCD GitOps method to Helm chart in yorkie-argocd helm chart.
  • Revise misconfigured values on helm charts.
  • Update README.md for helm chart updates.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #513 (d744267) into main (4539bfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   51.06%   51.06%           
=======================================
  Files          64       64           
  Lines        5697     5697           
=======================================
  Hits         2909     2909           
  Misses       2429     2429           
  Partials      359      359           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@krapie krapie marked this pull request as ready for review April 17, 2023 09:02
@hackerwins hackerwins self-requested a review April 17, 2023 09:05
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit a7dfa3c into main Apr 17, 2023
@hackerwins hackerwins deleted the update-charts branch April 17, 2023 09:05
@krapie krapie self-assigned this Apr 17, 2023
@krapie krapie added the enhancement 🌟 New feature or request label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants