Update go.mod to use v1.23 #1141
Conversation
WalkthroughThis pull request updates the Go version across multiple configuration files. Both workflow files now reference Go 1.23 instead of 1.21, and the Dockerfile’s base image has been switched accordingly. Additionally, the project's Changes
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
- Coverage 47.11% 38.49% -8.63%
==========================================
Files 83 165 +82
Lines 12333 25169 +12836
==========================================
+ Hits 5811 9688 +3877
- Misses 5935 14665 +8730
- Partials 587 816 +229 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
147-151: Inconsistent Setup-go Action Versions in CI Jobs.
The "complex-test" job usesactions/setup-go@v3while the build and bench jobs useactions/setup-go@v4. For consistency and to leverage improvements available in later versions, please update the complex-test job to use the same version as the other jobs.🧰 Tools
🪛 actionlint (1.7.4)
148-148: the runner of "actions/setup-go@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[warning] 147-147: wrong indentation: expected 6 but found 4
(indentation)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/base-docker-publish.yml(1 hunks).github/workflows/ci.yml(1 hunks)Dockerfile(1 hunks)go.mod(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- go.mod
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/base-docker-publish.yml
19-19: the runner of "actions/setup-go@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (4)
.github/workflows/base-docker-publish.yml (1)
18-21: Go Version Update and Setup Action Revision.
The workflow now explicitly sets up Go version 1.23, meeting the PR objective. However, note that the step usesactions/setup-go@v4, and static analysis indicates this version may be outdated. Consider upgrading to a newer version (e.g., v5) for improved compatibility and future-proofing.🧰 Tools
🪛 actionlint (1.7.4)
19-19: the runner of "actions/setup-go@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Dockerfile (1)
5-5: Dockerfile Base Image Update Confirmed.
The builder stage’s base image has been correctly updated from Go 1.21 to Go 1.23, aligning with the PR objective. Ensure that all dependent build steps remain compatible with Go 1.23..github/workflows/ci.yml (2)
16-17: Updated Go Version Environment Variable.
The environment variableGO_VERSIONhas been updated to'1.23', ensuring consistency across the CI jobs per the PR objective.
57-62: Consistent Go Setup in Build Job.
The build job correctly usesactions/setup-go@v4with the updatedGO_VERSION. However, as with other parts of the workflow, consider verifying if this action version meets current best practices.🧰 Tools
🪛 actionlint (1.7.4)
59-59: the runner of "actions/setup-go@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🪛 YAMLlint (1.35.1)
[warning] 58-58: wrong indentation: expected 6 but found 4
(indentation)
What this PR does / why we need it:
Bump up Go to v1.23
Which issue(s) this PR fixes:
Addresses #1140
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist:
Summary by CodeRabbit