feat: improve camera selection behavior #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the camera selection functionality to prevent user confusion due to lack of solid error handling. It includes the following improvements: - Ensures the camera field is required, displaying a warning if no camera is selected. - Fixes the camera state setting to correctly select the first device, preventing it from being overwritten with an empty string. - Displays a descriptive label when no camera devices are available. Additionally, this commit improves the codebase structure for better maintainability and readability.
eliteprox
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the camera selection functionality to prevent user confusion due
to lack of solid error handling. It includes the following improvements:
from being overwritten with an empty string.
Additionally, this commit improves the codebase structure for better maintainability
and readability.