fix: prevent AssertionError by setting max_workers to 1
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshith15
reviewed
Mar 11, 2025
varshith15
reviewed
Mar 11, 2025
varshith15
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #124 which is caused by concurrent worker processes loading the same models in certain workflows.
This change also handles WebRTC data channel errors during frame processing in
app.pyto resolve #135. Please note these are separate issues.max_workershad been set to5in #10 to allow for more than a single workflow to be executed simultaneously, however, we must refactor the solution to ensure that prompts are always queued to the same worker process, otherwise this error will occur. (See #73)This issue was also occurring intermittently midstream due to the active worker process queuing long enough to prompt comfystream api server to start a 2nd worker.