Skip to content

Commit

Permalink
default UI to no audio for UX (#82)
Browse files Browse the repository at this point in the history
  • Loading branch information
eliteprox authored Feb 21, 2025
1 parent 71c135d commit 8b54939
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion ui/src/components/settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ function ConfigForm({ config, onSubmit }: ConfigFormProps) {
setAudioDevices(audioDevices);
// Set default to first available microphone if no selection yet
if (selectedAudioDevice == "none" && audioDevices.length > 1) {
setSelectedAudioDevice(audioDevices[1].deviceId); // Index 1 because 0 is "No Audio"
setSelectedAudioDevice(audioDevices[0].deviceId); // Default to "No Audio" due to https://github.com/yondonfu/comfystream/issues/64
}
} catch (error) {
console.error("Failed to get audio devices: ", error);
Expand Down Expand Up @@ -265,12 +265,20 @@ function ConfigForm({ config, onSubmit }: ConfigFormProps) {
const handleCameraSelect = (deviceId: string) => {
if (deviceId !== selectedVideoDevice) {
setSelectedVideoDevice(deviceId);
// Unselect audio device when video is selected
if (deviceId !== "none") {
setSelectedAudioDevice("none");
}
}
};

const handleMicrophoneSelect = (deviceId: string) => {
if (deviceId !== selectedAudioDevice) {
setSelectedAudioDevice(deviceId);
// Unselect video device when audio is selected
if (deviceId !== "none") {
setSelectedVideoDevice("none");
}
}
};

Expand Down

0 comments on commit 8b54939

Please sign in to comment.