Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook: Modify url of webhook message #284

Closed
wants to merge 1 commit into from

Conversation

hongwonjun
Copy link
Collaborator

Slack alarm 에서 웹페이지 링크가 모두 localhost 로 되어 있는 버그를 수정하기 위한 Pull Request 입니다.

급하게 변경했는데, 리뷰 주시면 바로 반영해서 수정하겠습니다.

@doortts
Copy link
Collaborator

doortts commented Sep 6, 2017

@hongwonjun
commit message 의 경우 commit prefix로 영향받는 영역을 area로 표시 하거나 애마할 경우 생략하고 있습니다. 번거로우시겠지만 추후 검색을 위해 fix 대신 webhook으로 area 지칭을 변경해주시겠어요?

@hongwonjun
Copy link
Collaborator Author

@doortts 변경했습니다.

@hongwonjun hongwonjun changed the title fix: Modify url of webhook message Webhook: Modify url of webhook message Sep 6, 2017
doortts added a commit that referenced this pull request Sep 8, 2017
@doortts
Copy link
Collaborator

doortts commented Sep 8, 2017

@hongwonjun next 브랜치로 머지되었습니다. 고맙습니다.

@doortts doortts closed this Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants