Issue 112 - 이슈 글을 쓸 때 단일 라벨 복구가 안되는 문제 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! 쉽지 않은 수정이리가 생각해서 반쯤 기권하고 있었는데 고맙습니다. 코드 파악이 쉽지 않았을텐데 솔직히 놀랐습니다! @helols 보구싶구마이!! |
- There is not "label.failed" message key so it causes that the message to not display correctly.
See: Yona Github issue yona-projects#112
helols
force-pushed
the
iss-112-label-issue
branch
from
b5db52a to
bb83dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 이슈 글을 쓸 때 단일 라벨 복구가 안되는 문제 #112
Yona에서 사용 하는 데이터셋은 Select2가 지원하는 API로 이쁘게 처리 할수 있는 방법이 없어서.. (있을수도 있는데 제가 못 찾았었을수도 있습니다..) 싱글 라벨선택 될때, 기존에 선택되어서 숨겨진 녀석을 찾아서 다시 보이게 수정했습니다. 그리고
label.failed라는 메세지키가 없어서label.failedTo를 사용하긴 했는데.. 영어메세지에서Failed to Add label-A가 대문자로 나오는 문제가 있습니다. 어떻게 하는게 내부적인 룰인지 몰라서 일단 있는걸로 수정해보았습니다. 수정/의견 사항 있으면 알려주셔요.@doortts 새해복 많이 받으세요!