attachment: Use SHA-256 instead of SHA-1 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overwriting an existing attachment file maliciously is possible since Yona uses SHA-1 algorithm, which is known to be shattered[1], to digest the contents to generate the names of the attachment files. This fix ensures backward compatibility. Only new attachments have filenames generated by SHA-256 algorithm. Fortunately, the length of 'name' column of 'attachment' table is 255 which is enough to store SHA-256 which requires 64. [1]: https://shattered.it/
|
@benelog |
sjstyle
approved these changes
Feb 27, 2017
|
Yona 모든 버전에 취약점이 존재하며, 해당 커밋으로 문제가 해결되는 것을 확인하였습니다. 아직까지는 해당 취약점을 악용하는 것은 거의 불가능하므로 당장 패치해야하는 상황은 아닌것으로 파악했습니다. |
doortts
force-pushed
the
master
branch
3 times, most recently
from
a9dd787 to
53db075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwriting an existing attachment file maliciously is possible since
Yona uses SHA-1 algorithm, which is known to be shattered1, to digest
the contents to generate the names of the attachment files.
This fix ensures backward compatibility. Only new attachments have
filenames generated by SHA-256 algorithm. Fortunately, the length of
'name' column of 'attachment' table is 255 which is enough to store
SHA-256 which requires 64.