Skip to content

Commit

Permalink
user: Remove verbose name expression in mention
Browse files Browse the repository at this point in the history
  • Loading branch information
doortts committed Aug 11, 2017
1 parent 1899347 commit 0296a9d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions app/models/User.java
Original file line number Diff line number Diff line change
Expand Up @@ -991,4 +991,16 @@ public int compare(Project lhs, Project rhs) {
public boolean isLocked() {
return this.state == UserState.LOCKED || this.state == UserState.DELETED;
}

public String getPureNameOnly(){
String pureName = this.name;
String [] spliters = { "[", "(" };
for(String spliter: spliters) {
if(pureName.contains(spliter)){
pureName = this.name.substring(0, this.name.indexOf(spliter));
}
}

return pureName;
}
}
4 changes: 2 additions & 2 deletions app/utils/AutoLinkRenderer.java
Original file line number Diff line number Diff line change
Expand Up @@ -328,9 +328,9 @@ private static Link toValidUserLink(String userId) {
if( user.avatarUrl().equals(UserApp.DEFAULT_AVATAR_URL) ){
avatarImage = "";
} else {
avatarImage = "<img src='" + user.avatarUrl() + "' class='avatar-wrap smaller no-margin-no-padding vertical-top' alt='@" + user.loginId + "'> ";
avatarImage = "<img src='" + user.avatarUrl() + "' class='avatar-wrap smaller no-margin-no-padding vertical-top' alt='@" + user.name + " " + user.loginId + "'> ";
}
return new Link(RouteUtil.getUrl(user), "no-text-decoration", "<span data-toggle='popover' data-placement='top' data-trigger='hover' data-html='true' data-content=\"" + StringEscapeUtils.escapeHtml4(avatarImage + user.loginId) + "\">@" + user.name + "</span>");
return new Link(RouteUtil.getUrl(user), "no-text-decoration", "<span data-toggle='popover' data-placement='top' data-trigger='hover' data-html='true' data-content=\"" + StringEscapeUtils.escapeHtml4(avatarImage + user.name + " " + user.loginId) + "\">@" + user.getPureNameOnly() + "</span>");
}
}

Expand Down

0 comments on commit 0296a9d

Please sign in to comment.