Add option to select type of fallback sound #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
This was referenced Feb 23, 2025
|
LGTM. Should we also do #1837 or something like it though? I think we probably want these sounds to be normalized to some reasonable dB level. |
djahandarie
approved these changes
Feb 24, 2025
Normalizing the dB level would be nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the setting for turning on and off the fallback sound with a dropdown that allows users to select which fallback sound they want.
None,Click, orBloop. (if theres a better name for that sound than "bloop" let me know idk what to call it)Enough users seem to prefer the click that I've set that to be the default. No hard preference there though.