Integration tests #26
Conversation
We don't want everyone filling QA with test partners, so we are asking tests to be run against an integration environment.
Small problem with this: When I run `python setup.py test`, all the tests pass, but I'm seeing the exit error described here: nose-devs/nose#629 - I'm on python 2.7.10 When I run `python setup.py nosetests`, everything works fine.
| self.assertEqual(sub['id'], self.subscription['id']) | ||
|
|
||
| # Not working: https://github.com/yola/yolapy/issues/21 | ||
| # def test_can_change_subscription_type(self): |
There was a problem hiding this comment.
This may be the closest thing I've seen to acceptable commented-out code... but I still don't like it.
Instead how about:
- Commit the test as functional
- Purge the test with a commit message linking the blocking issue
- When (whoever) resolves the issue, they can revert the purge
There was a problem hiding this comment.
I like that, but with one more step:
- comment on the issues to restore the test in the linked commits
There was a problem hiding this comment.
I was hoping that the github generated ref would be good enough but a comment is definitely better
There was a problem hiding this comment.
I removed the commented-out tests.
|
|
||
|
|
||
| from yolapy.services import Yola | ||
| from tests.test_integration.test_settings import url, auth |
There was a problem hiding this comment.
I101 Imported names are in the wrong order. Should be auth, url
There was a problem hiding this comment.
This seems like the type of helper that shouldn't live in the root of the source.
I do like the utility. Thoughts on moving it to __main__.py in yolapy and calling it via?:
python -m yolapy
There was a problem hiding this comment.
This doesn't seem like the main program of yolapy. I don't think yolapy has a main program/purpose. This is a developer tool. I can't think of an alternative suggestion that isn't root though...
Will restore after #24 is resolved.
| attrs = { | ||
| 'id': 'WL_TEST-%s' % unique_id, | ||
| 'name': 'TEST', | ||
| 'parent_partner_id': 'WL_YOLA', |
There was a problem hiding this comment.
Using WL_YOLA here restricts which user/pass you can run the test settings.
Maybe that's okay?
This tripped me up when running. Suggesting either:
- this line use the client's configured username
- update the test sample to use username
WL_YOLA
There was a problem hiding this comment.
Good catch. Fixed hard-coded partner ids in 86380d6
This will make it more flexible when changing user/pass in test settings. See #26 (comment)
This was a pattern that started repeating itself after I wrote the first couple tests, but it became a noise word that was repeated in every test. Note: I typically dislike "test_[method_name]" names for unit tests, but for integration tests like this, I think they are just fine. See #26 (comment)
This is a public repo See #26 (comment) and #26 (comment)
| integration environment and edit the test settings:: | ||
|
|
||
| $ cp tests/test_integration/test_settings.py.sample \ | ||
| $ tests/test_integration/test_settings.py |
There was a problem hiding this comment.
No need for the prompt ($) on this line, as it's a continuation of the previous line
|
LGTM... after the small doc change: 👍 |
|
|
||
| yola = Yola(url=url, auth=auth) | ||
|
|
||
| print 'The current directory has been added to the beginning of sys.path' |
Closes #3
Also fixes a couple bugs found thanks to the tests